Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

210: One Person will be Artillery Trained when hiring minimum complement for an artillery-armed unit #2887

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

Windchild292
Copy link
Contributor

This fixes #210

…l when hiring the full complement for units with an artillery weapon
@Windchild292 Windchild292 self-assigned this Sep 25, 2021
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #2887 (70103a1) into master (67d59c5) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2887      +/-   ##
============================================
- Coverage     10.63%   10.63%   -0.01%     
  Complexity     3887     3887              
============================================
  Files           721      721              
  Lines        100582   100594      +12     
  Branches      16425    16427       +2     
============================================
- Hits          10699    10697       -2     
- Misses        88501    88516      +15     
+ Partials       1382     1381       -1     
Impacted Files Coverage Δ
...gn/personnel/generator/AbstractSkillGenerator.java 0.00% <0.00%> (ø)
...personnel/generator/DefaultPersonnelGenerator.java 0.00% <0.00%> (ø)
...ign/personnel/generator/DefaultSkillGenerator.java 0.00% <0.00%> (ø)
...campaign/unit/actions/HirePersonnelUnitAction.java 45.78% <0.00%> (-4.22%) ⬇️
.../mekhq/campaign/universe/FactionBorderTracker.java 68.87% <0.00%> (-2.05%) ⬇️
MekHQ/src/mekhq/campaign/mission/AtBContract.java 18.98% <0.00%> (-0.30%) ⬇️
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 59.60% <0.00%> (+0.20%) ⬆️
MekHQ/src/mekhq/campaign/universe/Faction.java 66.66% <0.00%> (+0.64%) ⬆️
.../mekhq/campaign/mission/enums/AtBContractType.java 13.24% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d59c5...70103a1. Read the comment docs.

@Windchild292 Windchild292 merged commit 67aa794 into MegaMek:master Sep 29, 2021
@Windchild292 Windchild292 deleted the dev_Windchild_210 branch September 29, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artillery Crews hired using "hire full compliment" automatically get artillery skill
2 participants